fix: localize and unify toasts and confirmations#99
fix: localize and unify toasts and confirmations#99OsakaLOOP wants to merge 1 commit intobefore-refractorfrom
Conversation
- Extracted SweetAlert2 logic into a dedicated `showConfirm` wrapper in `src/utils/confirm.ts`. - Replaced all usages of native `window.confirm()` and `confirm()` with the async `showConfirm()` wrapper, properly localizing their prompts across map pins, folder management, trip editing, and settings. - Replaced basic native `alert()` calls with `toast.error()` or `toast.success()` to unify the notification aesthetic and properly track dismissals. - Updated `public/locales/` JSON files (zh-CN, zh-TW, en, ja-JP) to include the new translation keys for system alerts, toasts, and confirmation dialogs. - Updated async/await logic in component event handlers to accommodate the new async sweetalert checks. Co-authored-by: OsakaLOOP <68284076+OsakaLOOP@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR completes the localization of all missing popups, alerts, and toasts across the codebase. Native UI blockers like
window.confirmandwindow.alerthave been replaced withsweetalert2andreact-hot-toastto provide a non-blocking and visually unified experience.Changes:
src/utils/confirm.tshelper to wrap SweetAlert2 configurations.alert()usage totoast()(e.g.TripEditor.tsx,TripsPage.tsx).confirm()usage toshowConfirm()(e.g.PinEditor.tsx,AppLayout.tsx,TripsPage.tsx,WalkTripEditor.tsx).PR created automatically by Jules for task 10362150891826168911 started by @OsakaLOOP